[Multiple-Profile]feat: define trigger app restart guard

[criticalAY]

Note

Assisted-by: Gemini Pro - unit tests (it was fairly simple so let Gemini Handle)

• All unit test are written by Gemini Pro but I have verified each one of them

Purpose / Description

Handle restart app logic i.e. complete the TODO that was left beind, put a guard rail to avoid accidental profile switches

Fixes

• Fixes part of Add support for profiles #18117

Approach

NA

How Has This Been Tested?

Unit test

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

How about (untested; needs unit tests fixing):

Index: AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt b/AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt
--- a/AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt	(revision b3918400cb409c6746548d879f47e6529873fb94)
+++ b/AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileManager.kt	(date 1775413679178)
@@ -154,13 +154,10 @@
     /**
      * Persists [newProfileId] as the active profile.
      *
-     * **Do not call directly.** Use [ProfileSwitchGuard] to ensure
-     * backup/sync safety checks are run before switching.
-     * Direct calls bypass all safety guards and may corrupt data.
-     *
      * @param newProfileId The [ProfileId] to activate on next launch.
      */
     @VisibleForTesting
+    context(_: ProfileSwitchContext)
     fun switchActiveProfile(newProfileId: ProfileId) {
         Timber.i("Switching profile to ID: $newProfileId")
         profileRegistry.setLastActiveProfileId(newProfileId)
@@ -336,6 +333,17 @@
         fun contains(id: ProfileId): Boolean = globalPrefs.contains(id.value)
     }
 
+    /**
+     * A context representing that it is safe to switch profiles
+     *
+     * - Backups are not occurring
+     * - Sync is completed
+     * - Collection is not open
+     *
+     * @see ProfileSwitchGuard
+     */
+    object ProfileSwitchContext
+
     companion object {
         private const val MAX_ATTEMPTS = 10
         const val PROFILE_REGISTRY_FILENAME = "profiles_prefs"
Index: AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileSwitchGuard.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileSwitchGuard.kt b/AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileSwitchGuard.kt
--- a/AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileSwitchGuard.kt	(revision b3918400cb409c6746548d879f47e6529873fb94)
+++ b/AnkiDroid/src/main/java/com/ichi2/anki/multiprofile/ProfileSwitchGuard.kt	(date 1775413676674)
@@ -17,6 +17,8 @@
 
 package com.ichi2.anki.multiprofile
 
+import com.ichi2.anki.multiprofile.ProfileManager.ProfileSwitchContext
+
 /**
  * Guards profile switching by running a set of safety checks
  * before delegating to [ProfileManager].
@@ -70,7 +72,7 @@
         }
 
         return if (activeBlockedReasons.isEmpty()) {
-            profileManager.switchActiveProfile(newProfileId)
+            with(ProfileSwitchContext) { profileManager.switchActiveProfile(newProfileId) }
             Result.Success
         } else {
             Result.Blocked(activeBlockedReasons)

[criticalAY]

Surely, thankyou for the patch! (updated test)

[david-allison]

Feels over-engineered vs closing the collection, but I'll take it on trust.

LGTM

[mikehardy]

seems reasonable enough - this would allow us to expose reasons to the user vs just closing collection, seems that could have UX value