feat(reminders): reminder troubleshooting UI [DEV-Only]#20724
feat(reminders): reminder troubleshooting UI [DEV-Only]#20724mikehardy merged 3 commits intoankidroid:mainfrom
Conversation
|
@david-allison fyi: took conflicts from the recent merge |
|
@criticalAY feel free to flag as "needs author reply" in future, I've got 14 open PRs and de-conflict then daily |
ericli3690
left a comment
ericli3690
left a comment
There was a problem hiding this comment.
I previously reviewed this on David's fork and approved it there. Gave it another skim just now and it looks even better now. Nice extension functions. Thanks again David!
criticalAY
added
the
Needs Author Reply
For now, this only shows the status, not the checks * Adds a menu item on reminders to open troubleshooting * Display the overall status of checks Influenced by Google 'Battery Health' Assisted-by: Claude Opus 4.6
Assisted-by: Claude Opus 4.6
Allow a user to tap a troubleshooting issue and open an appropriate screen to fix the issue Assisted-by: Claude Opus 4.6
david-allison
removed
Needs Author Reply
david-allison
force-pushed
the
reminder_troubleshooting
branch
from
ae7b77e to
584ea48
Compare
david-allison
added
Needs Second Approval
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
worthy for a dev-only opening salvo
please open related issue that will survive this PR merge with a todo list for getting it to production
| * This handles cases that [onResume] misses, such as toggling battery saver | ||
| * from the notification shade, which doesn't pause/resume the activity. |
There was a problem hiding this comment.
Stuff like this is why having an app reliably notify you - and help you get to the point where notifications are reliable - is so fiendishly difficult. Nice
| is TroubleshootingCheck.ExactAlarmPermission -> "Alarms & reminders permission" | ||
| } | ||
|
|
||
| // TODO: move to string resources |
There was a problem hiding this comment.
I'm okay with this for dev only but really really needs something that helps track / gate it, should be noted on a related issue (does not seem to be one right now?) that survives the merge of this PR in still open state, noting the steps to promote it to public vs dev-only
There was a problem hiding this comment.
This should be within the scope of #19473, so I don't think we need to create another issue, that one should cover moving these to string resources.
| fragment.requestPermissionThroughDialogOrSettings( | ||
| activity = fragment.requireActivity(), | ||
| permission = Manifest.permission.POST_NOTIFICATIONS, | ||
| permissionRequestedFlag = Prefs::notificationsPermissionRequested, | ||
| permissionRequestLauncher = fragment.notificationPermissionLauncher, |
There was a problem hiding this comment.
also so hard to get correct, I remember that PR going in for the jank Android "can you request notification permission or not?" stuff
mikehardy
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
4 participants
Note
Assisted-by: Claude Opus 4.6
The initial design was implemented by Claude, I've spent a few hours fixing up issues and refactoring
Some icons are by Claude
Huge thanks to @ColbyCabrera @LUwUcifer, @ShaanNarendran and @ericli3690 for all the design feedback!
[Please feel free to review the final PR/design]
Purpose / Description
In a previous commit, a ViewModel was added, this UI exposes the ViewModel, with a design similar to Google's Battery health
Checks are inspired by Daylio
Links
Approach
A handler is added to detect a refresh via focus change, as pulling down the navigation drawer does not call
onResume, so 'do not disturb' etc... would not have been detected.How Has This Been Tested?
API 33 emulator, @ericli3690 confirmed on API 25. My Google Pixel 9 Pro
reminder_troubleshooting.webm
Checklist