Improve deck selection dialog code#20889
Open
lukstbit wants to merge 4 commits intoankidroid:mainfrom
Open
Conversation
lukstbit
added
Needs Review
Next version
david-allison
requested changes
Apr 30, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
One bug, LGTM in general. I strongly dislike this selector, thank you!!!
lukstbit
force-pushed
the
refactor_deckSelectionDialogCode
branch
from
7a7fdfb to
71e7d55
Compare
Identical behavior with BundleCompat.getParcelable(). Due to the formatter using BundleCompat.getParcelable is verbose and this extension simplifies call sites a bit.
Adds all the parameters that will be used by the dialog. Also simplifies the call sites by using default parameters. "summary" and "restore default" arguments were combined into a single string property, it's only used by CardTemplateEditor and one implies the other.
lukstbit
force-pushed
the
refactor_deckSelectionDialogCode
branch
from
71e7d55 to
b12e05c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Improves and simplifies the code in DeckSelectionDialog for further changes.
Note: most of the changes are simple, the only change that is more complex was done in CardBrowser/CardBrowserFragment because we have multiple actions that can be done in response to a deck being selected.
Fixes
DeckSpinnerSelectionand recodeDeckSelectionDialog#18875How Has This Been Tested?
Ran the tests, verified deck selection where it was used.
Checklist