feat(deck-options): handle computeMemory progress#20909
Open
david-allison wants to merge 1 commit intoankidroid:mainfrom
Open
feat(deck-options): handle computeMemory progress#20909david-allison wants to merge 1 commit intoankidroid:mainfrom
david-allison wants to merge 1 commit intoankidroid:mainfrom
Conversation
* Enable FSRS * Save * A computeMemory progress dialog is shown Fixes 16642
Contributor
I realize that you want to avoid unintended bugs, but as I noted on the issue, most users won't even see the progress in the next version because it will be sped up by >10 times (10.18s → 853ms). So, you might want to consider including this in 2.24 if you feel that this is a low-risk change. |
Member
Author
|
I'd rather keep patch releases for patches rather than sneak functionality in. @mikehardy FYI, open to disagreement. I'm hoping we get to 2.25 pretty quickly |
Member
|
Fewer people even having the potential to see actually means it's even lower priority- same risk of bugs and smaller benefits. We will hopefully do 2.25 quickly- 2.24 (and all its betas) built right off main so we're currently very stable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
We now show more information than just 'Processing'
Fixes
Approach
computeMemoryHow Has This Been Tested?
computeMemoryprogress dialog is shownScreen_recording_20260430_201904.webm
Learning (optional, can help others)
Out 'Amount' progress indicator abstraction isn't entirely correct. In
computeMemory, we have a label, we do not want to formatAmountas a string, but we do want to use it to display as progress in the dialog.Checklist