Prevents IllegalArgumentException in Card Browser#20934
Open
Galal-20 wants to merge 1 commit intoankidroid:mainfrom
Open
Prevents IllegalArgumentException in Card Browser#20934Galal-20 wants to merge 1 commit intoankidroid:mainfrom
Galal-20 wants to merge 1 commit intoankidroid:mainfrom
Conversation
…to verify edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes a common Card Browser crash IllegalArgumentException that happens when the calculated ripple/focus color is the same as the backdrop color.
Fixes
Approach
I used a defensive fallback logic in place of a necessary requirement that might not work with extreme colors:
This ensures the colors will always be different and users always get a visible response pressed state even when using extreme background colors.
How Has This Been Tested?
Tested manually on: Android Emulator (API 33, 34, 37) and Physical device.
Also i have added comprehensive Unit Tests to verify this logic.
UI:
c.mov
Checklist