Skip to content

fix(card-browser): error message when entering 'and'#20999

Open
david-allison wants to merge 2 commits intoankidroid:mainfrom
david-allison:r8-demangle
Open

fix(card-browser): error message when entering 'and'#20999
david-allison wants to merge 2 commits intoankidroid:mainfrom
david-allison:r8-demangle

Conversation

@david-allison
Copy link
Copy Markdown
Member

@david-allison david-allison commented May 8, 2026

Note

Assisted-by: Claude Opus 4.7 - test

Purpose / Description

  • Exception class names were mangled
  • Exception class names were shown

Fixes

Approach

  • proguard rule
  • special-case libanki InvalidSearchException

How Has This Been Tested?

Unit tested

API 37 emulator

Screenshot 2026-05-08 at 15 00 08

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

AnkiDroid Translations and others added 2 commits May 8, 2026 14:50
The message already starts with 'invalid search'

So we do not need to show the exception name(s)

Fixes 20998

Assisted-by: Claude Opus 4.7 - test
@ZornHadNoChoice

This comment was marked as resolved.

@david-allison david-allison changed the title fix)card-browser): error message when entering 'and' fix(card-browser): error message when entering 'and' May 8, 2026
@david-allison
Copy link
Copy Markdown
Member Author

david-allison commented May 8, 2026

The dialog looks weird.

That's the dialog with the 'OK' button focused - I believe API 37 is still in beta, or I have a beta emulator

[There's a typo in the title and the AI callout is a quote.]

Fixed, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Card Browser: 'InvalidSearchException' message formatting R8 mangles exception names [Browser] bad error messages

2 participants