Fix card/notes export as text and sharing#21000
Merged
BrayanDSO merged 2 commits intoankidroid:mainfrom May 8, 2026
Merged
Conversation
david-allison
approved these changes
May 8, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
LGTM. Could do with a needsTest
| supportFragmentManager.setFragmentResultListener(REQUEST_EXPORT_SHARE, this) { _, bundle -> | ||
| shareFile( | ||
| bundle.getString(KEY_EXPORT_PATH) ?: error("Missing required exportPath!"), | ||
| path = bundle.getString(KEY_EXPORT_PATH) ?: error("Missing required exportPath!"), |
david-allison
added
Needs Second Approval
Introduces a flag to distinguish between sharing a text file or an apkg file after exporting.
Was returning Activity.intent, the only alternative path was incorrect and would fail every time.
lukstbit
force-pushed
the
fix_exportTextShare
branch
from
cd2e88c to
54ce86a
Compare
BrayanDSO
approved these changes
May 8, 2026
BrayanDSO
added
Pending Merge
github-actions
Bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
When sharing notes and card as a text file we created the share intent for an application/apkg which then failed. I passed a flag to distinguish between creating a share intent for an apkg or text file so the import succeeds.
Fixes
How Has This Been Tested?
Checked exporting everything and sharing back.
Checklist