fix: menu items drag#21047
Open
BrayanDSO wants to merge 2 commits into
Open
Conversation
only the initial and final elements were swapped. On a quick move, intermediate elements wouldn't get correctly moved. so now, swap each element sequentially
the items list is fixed, so it should improve the recycler view inner performance
david-allison
approved these changes
May 15, 2026
| if (toPosition == 0) return false | ||
|
|
||
| Collections.swap(items, fromPosition, toPosition) | ||
| if (fromPosition < toPosition) { |
Member
There was a problem hiding this comment.
Please extract to a well named extension method: reposition or similar with docs on how it differs from swap
Contributor
|
LGTM! |
david-allison
added
Needs Second Approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Note
Assisted-by: Gemini 3.1 Pro - diagnostics
Fixes
How Has This Been Tested?
Emulator 37
Dragged elements quickly on the reviewer menu settings. No visual bugs
Checklist
Please, go through these checks before submitting the PR.