Skip to content

feat: move and rename "Safe display" pref #21079

Merged
lukstbit merged 4 commits into
ankidroid:mainfrom
BrayanDSO:feat/anim
May 19, 2026
Merged

feat: move and rename "Safe display" pref #21079
lukstbit merged 4 commits into
ankidroid:mainfrom
BrayanDSO:feat/anim

Conversation

@BrayanDSO
Copy link
Copy Markdown
Member

@BrayanDSO BrayanDSO commented May 18, 2026

Purpose / Description

to the accessibility settings

note: the "use safer method for drawing cards" part apparently does nothing, based on the current uses of the preference

Approach

In the commits

How Has This Been Tested?

Emulator 31

Screen_recording_20260518_115911.webm

FAB pressed color is bugged, I know. Already fixed on a rebase

Screen_recording_20260518_123750.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions
Copy link
Copy Markdown
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • PreferencesScreenshotTest: 2 changes
All 2 changed screenshots

PreferencesScreenshotTest

  • AccessibilitySettingsFragment_compare.png
  • AdvancedSettingsFragment_compare.png

Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/utils/AnimUtils.kt
@david-allison
Copy link
Copy Markdown
Member

Timebox 12 hours for a second approval, then merge

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 18, 2026
Comment thread AnkiDroid/src/main/java/com/ichi2/anki/DeckPickerFloatingActionMenu.kt Outdated
@BrayanDSO BrayanDSO force-pushed the feat/anim branch 2 times, most recently from 59eb87f to 1c5d75b Compare May 19, 2026 01:27
Copy link
Copy Markdown
Contributor

@Giyutomioka-SS Giyutomioka-SS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

BrayanDSO added 4 commits May 19, 2026 06:47
only the "animator" setting is necessary for that goal. The other ones are actually unrelated
to the accessibility settings

note: the "use safer method for drawing cards" part apparently does nothing, based on the current uses of the preference
it could be confused or conflict with `android.view.animation.AnimationUtils`
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 19, 2026
@lukstbit lukstbit added this pull request to the merge queue May 19, 2026
Merged via the queue into ankidroid:main with commit 8ef7715 May 19, 2026
20 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 19, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants