Fix: restore keyboard/D-pad control of deck picker FAB menu#21201
Open
criticalAY wants to merge 1 commit into
Open
Fix: restore keyboard/D-pad control of deck picker FAB menu#21201criticalAY wants to merge 1 commit into
criticalAY wants to merge 1 commit into
Conversation
criticalAY
added
the
Blocked by dependency
The main FAB registered two OnKeyListeners in init. A View keeps only the last one, so the second registration silently overwrote the first, dropping ENTER/DPAD_CENTER opening the menu when closed and ESCAPE closing it when open. Consolidate into a single OnKeyListener and remove the duplicate, keeping behavior consistent with fabMainClickListener. Add regression tests for the ENTER and ESCAPE paths.
criticalAY
force-pushed
the
fix-action-fab
branch
from
949006a to
ba982e3
Compare
criticalAY
removed
Blocked by dependency
david-allison
requested changes
Jun 4, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
One missing annotation as a blocker, rest LGTM, cheers!
| assertThat("FAB menu opens on click", floatingActionMenu.isFABOpen, equalTo(true)) | ||
| } | ||
|
|
||
| fun `FAB menu opens on ENTER key`() = |
Member
There was a problem hiding this comment.
Suggested change
| fun `FAB menu opens on ENTER key`() = | |
| @Test | |
| fun `FAB menu opens on ENTER key`() = |
Contributor
Author
There was a problem hiding this comment.
I think i missed it when i was resolving conflicts thanks
david-allison
added
the
Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.8
Purpose / Description
Blocked by fix: FAB opens menu on accessibility click #21199The main FAB registered two OnKeyListeners in init so this fixes that
Fixes
Approach
See commit
How Has This Been Tested?
tests and manually tested on emulator
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.