Skip to content

tolerate unknown fields#62

Merged
anmonteiro merged 4 commits into
anmonteiro:masterfrom
joprice:tolerateUnknownFields
May 4, 2022
Merged

tolerate unknown fields#62
anmonteiro merged 4 commits into
anmonteiro:masterfrom
joprice:tolerateUnknownFields

Conversation

@joprice
Copy link
Copy Markdown
Contributor

@joprice joprice commented Dec 27, 2021

strict mode was not disabled for api_gateway_request_identity, so some new fields like cognitoAmr are causing body parsing to fail.

@anmonteiro
Copy link
Copy Markdown
Owner

Thanks!

@joprice
Copy link
Copy Markdown
Contributor Author

joprice commented Dec 27, 2021

@anmonteiro The nix build failed. I saw something similar before with cachix action being outdated, so I pushed a commit with updated cachix version to at least rule that out.

@joprice
Copy link
Copy Markdown
Contributor Author

joprice commented Dec 29, 2021

I'm not seeing mismatched hashes for menhir. I'm assuming that

         specified: sha256:168qd2r6aiic2l5n7gxx085avx3afsrs2vjgwzmkkayix4nak5pf
         got:       sha256:1nsw5qzax4qdj1i0ijbrqwa5frivrq2laqkq88d402cb82dxp85g

I tried updating the overlays in nix/sources.nix, but got an interesting new error:

error: attempt to call something which is not a function but a string with context

@anmonteiro
Copy link
Copy Markdown
Owner

I updated it recently, you need to use boot.nix instead of sources.nix

@anmonteiro
Copy link
Copy Markdown
Owner

@joprice don't worry about CI for now, I'll fix it soon.

@joprice
Copy link
Copy Markdown
Contributor Author

joprice commented Dec 30, 2021

It at least builds and dune test passes locally in nix-shell with my latest commit.

@anmonteiro anmonteiro force-pushed the tolerateUnknownFields branch from d8f8c4d to 5883125 Compare May 4, 2022 08:13
@anmonteiro anmonteiro merged commit 3068c5b into anmonteiro:master May 4, 2022
@joprice joprice deleted the tolerateUnknownFields branch January 4, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants