API Gateway v2 bindings#68
Merged
Merged
Conversation
Owner
|
Nice! A few comments:
|
Contributor
Author
Sounds good. I'll add a leading comment too, that it's explains it's AWS's confusing name for APIGv2, not what they need to use HTTPv2 support.
Trial and error against a minimal lambda function, as the docs are somewhat useless in telling you what is going to be included vs optional. |
anmonteiro
approved these changes
Mar 26, 2023
Owner
anmonteiro
left a comment
anmonteiro
left a comment
There was a problem hiding this comment.
Thanks! Can you add an try to CHANGES.md, please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bindings for API Gateway v2