chore: drop netbox v24 support#559
Merged
Merged
Conversation
Error 403 (due to missing token) has nothing to do with version not being supported: % NETBOX_URL=https://demo.netbox.dev annet show device-dump dmi01-akron-rtr01 ... File "/Library/Frameworks/Python.framework/Versions/3.14/lib/python3.14/site-packages/dataclass_rest/http/requests.py", line 19, in _on_error_default raise ClientError(response.status_code) dataclass_rest.exceptions.ClientError: 403 During handling of the above exception, another exception occurred: Traceback (most recent call last): ... File "/Users/azryve/src/github/annet/annet/adapters/netbox/provider.py", line 39, in storage_factory raise ValueError(f"Unsupported version: {status.netbox_version}") ^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'netbox_version'
azryve
force-pushed
the
chore/drop-netbox-v24-support
branch
from
1622dc0 to
bd896c9
Compare
Tishka17
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops support for netbox v24. This is follows the change in annetutil/annetbox#74
As stated in annetbox MR:
Its easier to drop it then pretend that its supported at the same capacity.