Env.all() caches process.env snapshot, preventing detection of env vars set after initialization

[jerome-benoit]

Description

Env.all() in packages/opencode/src/env/index.ts creates a frozen snapshot of process.env on first invocation via Instance.state():

const state = Instance.state(() => {
  return { ...process.env } as Record<string, string | undefined>
})

This snapshot is never refreshed. When Provider.list() calls Env.all() (line 834 in provider/provider.ts) to detect env-based providers, it uses this cached snapshot.

Consequence: If any environment variable (e.g., AICORE_SERVICE_KEY, OPENAI_API_KEY) is set after the first call to Env.all(), it will never be detected, and the provider will never appear in the connected list.

This affects plugins/extensions that set environment variables dynamically or load them asynchronously.

Root Cause

The singleton pattern was introduced in commit ee4437ff3 ("core: add provider test coverage for upcoming refactor") and the shallow copy was later added in 90f39bf67 ("core: prevent parallel test runs from contaminating environment variables") to isolate parallel tests.

While this works for test isolation, it breaks runtime behavior where env vars may be set after OpenCode initializes.

Plugins

oh-my-opencode (reported in code-yeongyu/oh-my-opencode#1635)

OpenCode version

1.1.51

Steps to reproduce

1. Start OpenCode without AICORE_SERVICE_KEY set
2. Set AICORE_SERVICE_KEY in the environment after OpenCode initializes
3. Call provider.list() API
4. Observe: sap-ai-core never appears in connected array

Screenshot and/or share link

N/A

Operating System

Linux

Terminal

N/A

[github-actions]

This issue might be a duplicate of existing issues. Please check:

• Env.set does not update process.env, breaking provider SDKs #11481: Env.set does not update process.env, breaking provider SDKs

Both issues relate to environment variable handling and provider detection. Feel free to ignore if this addresses a different specific case.

[jerome-benoit]

Suggested Fix

The snapshot was introduced to isolate parallel tests from contaminating each other's env vars. However, this breaks runtime behavior where env vars may be set after initialization.

Looking at packages/opencode/test/preload.ts, tests set OPENCODE_TEST_HOME to indicate test mode. A simple fix would be to only use the snapshot in test mode:

// packages/opencode/src/env/index.ts
export namespace Env {
  const state = Instance.state(() => {
    // Only create snapshot in test mode to isolate parallel tests
    // In production, read process.env directly to pick up late-set env vars
    if (process.env.OPENCODE_TEST_HOME) {
      return { ...process.env } as Record<string, string | undefined>
    }
    return process.env as Record<string, string | undefined>
  })
  // ...
}

This preserves test isolation while allowing runtime detection of env vars set after initialization.

Happy to submit a PR if this approach looks good.