Fix: Cmd+Return should make newline in textarea

[zokan121522]

Description

When pressing Cmd+Return (Mac) in the prompt textarea, it should insert a newline instead of being blocked.

Expected behavior

• Enter → submit
• Cmd+Return → newline ( salto de línea)

Current behavior

Cmd+Return is blocked by the meta/ctrl handler.

[zokan121522]

📝 Comment 1: Spec

Requisitos:

1. Cmd+Return → newline (salto de línea)
2. Return → submit (enviar)
3. Cmd+C → copy (debe seguir funcionando)

Escenarios:

• Cmd+Return con input vacío → newline
• Cmd+Return con texto → newline
• Return → submit
• Escape → exit

[zokan121522]

📝 Comment 2: Design

Approach:

Modificar handler onKeyDown en prompt/index.tsx líneas 949-952:

Antes:

if (e.meta || e.ctrl) {
  e.preventDefault()
  return
}

Después:

if (e.meta && e.name === "return") {
  // Allow: let it pass for newline
} else if (e.meta || e.ctrl) {
  e.preventDefault()
  return
}

Esto permite Cmd+Return pasar para acción newline.

[zokan121522]

📝 Comment 3: Tasks

• 1. Modificar handler en index.tsx
• 2. Testear Cmd+Return = newline
• 3. Testear Return = submit
• 4. Testear Cmd+C = copy

[github-actions]

This issue doesn't fully meet our contributing guidelines.

What needs to be fixed:

• The issue appears to be a bug report but does not use the bug report template. Required fields are missing: OpenCode version, steps to reproduce, operating system, and terminal being used.
• Please use one of the three issue templates (Bug Report, Feature Request, or Question) and fill in the required fields.

Please edit this issue to address the above within 2 hours, or it will be automatically closed.

---

This issue might be a duplicate of existing issues. Please check:

• Shift-return does not input newline since 1.0 #4046: Shift-return does not input newline since 1.0 (same symptom: modifier+Return not inserting a newline in the input)
• Keyboard keybinds configuration not working - input_newline: shift+enter ignored #11983: Keyboard keybinds configuration not working - input_newline: shift+enter ignored (related: newline keybind not functioning)
• [FEATURE]: Allow to Shift + enter to edit in next line without enter #9836: [FEATURE]: Allow to Shift + enter to edit in next line without enter (same underlying request)

For keybind-related issues, please also check our pinned keybinds documentation: #4997

If you believe this was flagged incorrectly, please let a maintainer know.

[zokan121522]

📝 Update: Shortcut changed

El shortcut correcto es Shift+Return (no Cmd+Return).

Cambios hechos:

1. prompt/index.tsx: e.shift && e.name === return
2. textarea-keybindings.ts: shift: true, action: "newline"

[zokan121522]

📝 Comment 4: Apply complete

Fix implementado en:

• Rama: fix/cmd-enter-newline
• Archivo: prompt/index.tsx

Cambios:

• Insert newline directamente en el texto del prompt
• Funciona Shift+Return y Ctrl+J

Testing:

• Shift+Return = newline
• Ctrl+J = newline
• Return = submit

[zokan121522]

📝 Comment 5: Verify

Resultado: ✅ FUNCIONA

Shift+Return y Ctrl+J ahora insertan newline en el textarea.

El fix fue usar input.setText() directamente en lugar de input.insertText().

[github-actions]

This issue has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new issue that follows our issue templates.