fix(provider): deep merge providerOptions in applyCaching #10323
+3
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, applyCaching used shallow spreading to merge providerOptions, which would completely overwrite nested keys like 'openaiCompatible'. This caused options set by normalizeMessages (e.g., reasoning_content for interleaved models) to be lost when applyCaching ran. Now using remeda's mergeDeep to properly preserve existing nested properties while adding cache control options. Fixes anomalyco#10241 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Collaborator
|
/review |
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10241
Previously,
applyCachingused shallow spreading ({...a, ...b}) to mergeproviderOptions, which would completely overwrite nested keys likeopenaiCompatible. This caused options set bynormalizeMessages(e.g.,reasoning_contentfor interleaved models) to be lost whenapplyCachingran.Changes
mergeDeepfrom remedamergeDeep()for both message-level and content-level providerOptionsNow using remeda's
mergeDeepto properly preserve existing nested properties while adding cache control options.Test Plan
🤖 Generated with Claude Code