feat: support headless authentication for chatgpt/codex #10890
Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
| }, | ||
| }, | ||
| { | ||
| label: "ChatGPT Pro/Plus (headless)", |
There was a problem hiding this comment.
codex defaults to this based on if it detects environment variables
https://github.com/openai/codex/blob/067922a734f4abb11ef3db7290daed4feeeda60c/codex-rs/core/src/env.rs#L25-L46
i wasnt sure about if that would work here because of how opencode has multiple clients, so i didn't include it
rgodha24
changed the title
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
rgodha24
force-pushed
the
openai-device-auth
branch
from
c3c1fa0 to
5ecc5f0
Compare
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| grant_type: "authorization_code", | ||
| code: data.authorization_code, | ||
| redirect_uri: `${ISSUER}/deviceauth/callback`, | ||
| client_id: CLIENT_ID, |
There was a problem hiding this comment.
Suggestion: This token exchange fetch doesn't check if the response is OK before parsing JSON. The existing exchangeCodeForTokens function (line 109-125) properly checks response.ok and throws an error on failure. Consider reusing that function or adding similar error handling here to avoid silent failures or confusing errors when the token exchange fails.
|
i have no clue what is wrong with the tests 😭 |
|
Not ur fault |
|
@rekram1-node this issue is why i didnt want to remove the option to choose the flow: openai/codex#9253 |
This reverts commit 7c14206.
|
Yeah i gotchu I was playing w/ something shouldnt have committed |
2 participants
What does this PR do?
opencode.device.auth.mov
add the option to use the device auth authorization method to sign in with chatgpt/codex subscription
closes #10421, closes #8274, and approved by dax on twitter
How did you verify your code works?
manual testing (in the video)
copied mostly off of the copilot implementation of a similar (not exactly the same for some reason?) pattern
opencode share url