feat(script): respect npm_config_registry for version lookup#11388
Open
bbartels wants to merge 4 commits intoanomalyco:devfrom
Open
feat(script): respect npm_config_registry for version lookup#11388bbartels wants to merge 4 commits intoanomalyco:devfrom
bbartels wants to merge 4 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
Author
|
@rekram1-node Could i have a quick review? :) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The script fetches from
registry.npmjs.orgto get the latest published version, but ignores the user's configured npm registry. This reads fromnpm_config_registryenv var (automatically set by npm/bun from user config) and falls back to the default.Useful for airgapped environments or internal mirrors.
How did you verify your code works?
npm config set registry https://internal-mirror/ bun run script/build.tsFixes: #11387