-
Notifications
You must be signed in to change notification settings - Fork 9.1k
fix: exclude k2p5 from reasoning variants #11918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exclude k2p5 from reasoning variants #11918
Conversation
Kimi For Coding provider uses 'k2p5' as model ID which bypasses the 'kimi' exclusion check. Confirmed with Moonshot official staff that Kimi-K2.5 does NOT support thinking budget configuration. This is a temporary fix - the correct solution is to update models.dev data to use 'kimi-k2.5' instead of 'k2p5'. Fixes #11917
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
wait so kimi for coding has 2 model ids that map to same thing? |
In fact, the model ID obtained via the https://api.kimi.com/coding/models endpoint is kimi-for-coding |
|
game to update it, I don't have a kimi for coding sub so I can't test unless I grab one |
|
@luisf371 they should not make any difference, it was a visual thing only their api doesnt support the variants |
|
That's fair but i think we are getting confused on the intent. Yes i understand that the Kimi Code API does not support control of the thinking token efforts (think alot, think little, etc) which is what "variants" typically control. I even installed their official kimi client and verified that you can select between thinking and non-thinking. Thank you for what you guys contribute! |
|
Yes that's true, we can add a non thinking variant |






Summary
k2p5to the exclusion list invariants()function to prevent Kimi K2.5 from incorrectly gettinghigh/maxthinking variantsDetails
The Kimi For Coding provider uses
k2p5as the model ID for Kimi K2.5, which does not contain the string "kimi". This causes it to bypass the exclusion logic and incorrectly receive thinking variants support.Confirmed with Moonshot official staff: Kimi-K2.5 does NOT support thinking budget configuration.
This is a temporary workaround. The correct solution is to fix the model ID in
models.devdata to usekimi-k2.5instead ofk2p5.Fixes #11917