fix: always fall back to native clipboard after OSC52 #11994
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSC52 may report success but not actually work in some terminals. Previously, the code would early-return if OSC52 returned true, skipping the native clipboard method (osascript on macOS). This change removes the early return so both methods are attempted, ensuring clipboard copy works reliably across all terminal configurations.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
Author
|
Fixes #11996 |
Collaborator
|
I'll introduce proper remote detection next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Clipboard copy stopped working in some terminals after #11744 introduced OSC52 clipboard support.
The issue is that
renderer.copyToClipboardOSC52()returnstrue(indicating it wrote the escape sequence), but the terminal may not actually support or have OSC52 enabled. The previous code would early-return, skipping the native clipboard method.Solution
Remove the early return so both OSC52 and the native method (osascript on macOS, xclip/wl-copy on Linux) are always attempted. This ensures clipboard copy works reliably across all terminal configurations.
Changes
packages/opencode/src/cli/cmd/tui/util/clipboard.ts— remove early return after OSC52Testing