fix: prevent memory leaks from AbortController closures #12024
Merged
+184
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Arrow functions like `() => controller.abort()` capture the entire lexical scope, including large request bodies. When attached to long-lived signals or timeouts, this memory cannot be reclaimed. Using `controller.abort.bind(controller)` only retains a reference to the controller itself, allowing request bodies to be GC'd. Changes: - Add `abortAfter` and `abortAfterAny` utilities in src/util/abort.ts - Update webfetch, websearch, and codesearch tools to use the utility - Add integration test proving ~13MB memory savings over 500 requests Inspired by similar fix in Claude Code that reduced memory by 1GB in long sessions.
MaxLeiter
force-pushed
the
fix/abort-controller-memory-leak
branch
from
18135d1 to
75aac32
Compare
Collaborator
|
/review |
Collaborator
|
Yeah good find, we figured we were making the same mistake somewhere haha |
Contributor
|
lgtm |
sgInnora
added a commit
to sgInnora/opencode
that referenced
this pull request
Feb 4, 2026
- AsyncQueue: add close()/drain() methods, iterator exits on close - Bash tool: use Buffer[] with 10MB ring buffer instead of unbounded string concat - LSP client: clear diagnostics map on shutdown, cap at 5000 entries - Bus: clear subscriptions map on instance dispose - PTY: use Buffer[] instead of string concat for session buffer - Process exit: call Instance.disposeAll() in main finally block Based on official v1.1.50 which includes AbortController closure fix (PR anomalyco#12024) Combines all 9 memory optimizations for maximum stability. Fixes: anomalyco#10913 Related: anomalyco#10914, anomalyco#12024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Inspired by https://x.com/jarredsumner/status/2017825694731145388. Definitely not expecting to see the same 1 gb saving but its at least more correct.
Arrow functions like
() => controller.abort()capture the entire lexical scope, including large request bodies. When attached to long-lived signals or timeouts, this memory cannot be reclaimed.Using
controller.abort.bind(controller)only retains a reference to the controller itself, allowing request bodies to be GC'd.How did you verify your code works?
see (AI generated)
abort-leak.test.ts. I am sure there's a better way to verify this fix, but I do not know what that way is.related issues
There are tons of memory leak issues: #9385
Relates to: #9385
(It might not actually fix that particular issue. But the contributing bot makes me put that there)