Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds system prompt support for Trinity models (e.g. via OpenRouter). When the model id contains "trinity", we use a dedicated prompt that: uses exactly one tool per message, waits for the result before continuing, uses the question tool when the request is vague, and avoids repeating the same tool with the same params. The prompt is a small change on top of the default: same content except the “Tool usage policy” and “Doing tasks” sections are replaced with these Trinity rules. Routing is a single check in SystemPrompt.provider() in system.ts before the default branch.
Closes #12146
How did you verify your code works?
Added a local system.test.ts that checks the Trinity prompt is returned for arcee-ai/trinity-large-preview:free, arcee-ai/trinity-mini, and arcee-ai/trinity-mini:free; those tests passed. Also ran OpenCode in the terminal (TUI), selected arcee-ai/trinity-large-preview:free via OpenRouter, sent a message, and used temporary debug logging to confirm the model was detected and the Trinity prompt was selected. Internal testing was done with prompts designed to trigger the behaviors we wanted to avoid (e.g. parallel tool calls, repeating the same tool with the same params, etc). Model behaviour was on par with expectations.