fix: PATCH /config writes to correct project config file#12347
Closed
saba-ch wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: PATCH /config writes to correct project config file#12347saba-ch wants to merge 1 commit intoanomalyco:devfrom
saba-ch wants to merge 1 commit intoanomalyco:devfrom
Conversation
Config.update() was writing to config.json which is never read by the config loader. Now writes to opencode.jsonc or opencode.json (whichever exists), matching the files the loader actually reads. Mirrors the existing globalConfigFile() pattern. Fixes anomalyco#4194 Fixes anomalyco#6984
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
6 tasks
5 tasks
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Config.update()writes toconfig.jsonin the project directory, but the config loader only readsopencode.jsoncandopencode.json— so project-level config updates viaPATCH /configare silently lost.This changes
update()to use a newprojectConfigFile()helper (mirrors the existingglobalConfigFile()pattern) that picks whichever ofopencode.jsonc/opencode.jsonalready exists, defaulting toopencode.json.Fixes #4194
Fixes #6984
How did you verify your code works?
All 57 config tests pass (
bun test test/config/config.test.ts). Updated the existing "updates config and writes to file" test to assert againstopencode.jsoninstead ofconfig.json.