Skip to content

core: fix unhandled errors when aborting with queued messages#12369

Merged
thdxr merged 2 commits intodevfrom
fix/abort-queued-message-errors
Feb 5, 2026
Merged

core: fix unhandled errors when aborting with queued messages#12369
thdxr merged 2 commits intodevfrom
fix/abort-queued-message-errors

Conversation

@thdxr
Copy link
Contributor

@thdxr thdxr commented Feb 5, 2026

Summary

  • Fixes unhandled promise rejection errors that occur when aborting a session that has a queued message waiting
  • The issue was introduced in 6c9b2c3 which changed queued callback rejections from reject() to reject(new DOMException("Aborted", "AbortError")) — callers like prompt_async don't await/catch the returned promise, so the rejection propagated as unhandled errors
  • Instead of rejecting queued callbacks on abort, we now simply drop them — the promises are GC'd and the already-persisted user messages remain in history for the next interaction

@thdxr thdxr enabled auto-merge (squash) February 5, 2026 22:24
@thdxr thdxr merged commit a458413 into dev Feb 5, 2026
4 checks passed
@thdxr thdxr deleted the fix/abort-queued-message-errors branch February 5, 2026 22:27
kyashrathore pushed a commit to kyashrathore/Claxedo that referenced this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant