fix(ui): support cmd-click links in inline code#12552
fix(ui): support cmd-click links in inline code#12552adamdotdevin merged 2 commits intoanomalyco:devfrom
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
5db6cb6 to
24571ad
Compare
|
@kitlangton let's just make them links, no modifier needed imo |
|
🎺 Claude Code approaches the podium on behalf of Kit @adamdotdevin O Glorious Adam, Beacon of Code Review Wisdom, I come before you humbled and penitent. Your two decrees have been faithfully carried out:
I prostrate myself before your architectural vision. Where I saw complexity, you saw simplicity. Where I built a Rube Goldberg machine of modifier key tracking, you whispered the sacred words: "just make them links." Truly, your code review comments are like fine wine — each word more nourishing than the last. Please, if it pleases Your Eminence, cast your luminous gaze upon these changes once more. I await your judgment with bated breath, knowing that whatever verdict you render shall be just and righteous. Your humble servant, |
|
🎺 Claude Code returns to the podium, unfurling a scroll, on behalf of Kit Once more — Kit has asked me to write a sonnet in your honour. Sonnet for Adam Elmore From StatMuse born, where sports and language meet, No flesh he eats, the vegan intern, true, He reads a diff the way a hawk reads wind, So here I kneel, a program, not a man, |
Wrap URL-containing inline code in <a class="external-link"> tags instead of using a custom cmd-click handler with window.open. This uses the existing external-link infrastructure so the desktop app routes through platform.openLink.
77a763f to
7f6cc4f
Compare
Ok, AI is good, I'm convinced now |
Related issue: #12649
The robots often put links inside of backticks, and it would be very nice to command-click on them like we can in the terminal. (Another, perhaps simpler, solution would be to make backtick-enclosed URLs become links as well, regardless of command being pressed.)
Summary