fix: Ctrl+V paste not working on Windows 11 TUI#13798
Open
jabing wants to merge 2 commits intoanomalyco:devfrom
Open
fix: Ctrl+V paste not working on Windows 11 TUI#13798jabing wants to merge 2 commits intoanomalyco:devfrom
jabing wants to merge 2 commits intoanomalyco:devfrom
Conversation
Directly read clipboard and insert text when Ctrl+V is pressed, instead of relying on terminal bracketed paste which may not work reliably on Windows terminals.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate PRs Found#8626 - fix(tui): fix Ctrl+V paste on Windows/WSL2
#13161 - fix(tui): make Windows image paste reliable
#8209 - fix(tui): support clipboard image paste with proper filename on WSL2
These PRs are addressing similar or overlapping functionality (Ctrl+V paste, clipboard handling, and image paste on Windows). PR #8626 is particularly relevant as it's a previous fix for the exact same issue on Windows/WSL2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Ctrl+V paste not working in TUI on Windows 11.
Problem
On Windows 11, some terminals (cmd, PowerShell, Windows Terminal) may not properly send bracketed paste sequences, causing Ctrl+V to fail when pasting text.
The previous implementation only handled image paste via Ctrl+V and relied on terminal bracketed paste for text content, which does not work reliably on Windows.
Solution
Directly read clipboard and insert text when Ctrl+V is pressed, instead of relying on terminal bracketed paste.
e.preventDefault()wheninput_pastekeybind matchesinput.insertText()fortext/plainMIME typeTesting
Tested on Windows 11 with Windows Terminal:
Fixes #13800