Skip to content

fix(desktop): avoid sidecar health-check timeout on shell startup#13925

Merged
Brendonovich merged 2 commits intoanomalyco:devfrom
ysm-dev:fix/desktop-sidecar-shell-timeout
Feb 17, 2026
Merged

fix(desktop): avoid sidecar health-check timeout on shell startup#13925
Brendonovich merged 2 commits intoanomalyco:devfrom
ysm-dev:fix/desktop-sidecar-shell-timeout

Conversation

@ysm-dev
Copy link
Contributor

@ysm-dev ysm-dev commented Feb 17, 2026

Fixes #13926

What does this PR do?

Desktop sidecar startup currently runs through an interactive login shell (-il). On some machines with heavier interactive shell init, this delays sidecar startup until the desktop health check times out.

This switches sidecar spawn to non-interactive login mode (-l -c) so login env setup is still applied without interactive shell hooks. It also fixes kill-channel handling so we only kill the child on an explicit kill signal, not when the channel closes.

How did you verify your code works?

  • Reproduced the failure locally with bun dev:desktop (Health check timed out).
  • Confirmed shell-related behavior with SHELL=/bin/sh bun dev:desktop.
  • Verified startup works again after this change with default shell.
  • Ran cargo check in packages/desktop/src-tauri.

@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@ysm-dev
Copy link
Contributor Author

ysm-dev commented Feb 17, 2026

Thanks for the catch — I opened #13926 and linked it in the PR description via Fixes #13926.

@Brendonovich Brendonovich enabled auto-merge (squash) February 17, 2026 15:29
@Brendonovich Brendonovich merged commit d055c1c into anomalyco:dev Feb 17, 2026
6 checks passed
motionharvest added a commit to motionharvest/opencode that referenced this pull request Feb 17, 2026
* ci: use `useblacksmith/stickydisk` on linux runners only (anomalyco#13909)

* core: keep message part order stable when files resolve asynchronously (anomalyco#13915)

* ci: fixed Rust cache for 'cargo install' in publish.yml (anomalyco#13907)

* ci: fixed missing if condition (anomalyco#13934)

* Hide server CLI on windows (anomalyco#13936)

* zen: glm 5 free

* wip: zen

* ci: update triage workflow (anomalyco#13944)

* fix(app): keep Escape handling local to prompt input on macOS desktop (anomalyco#13963)

* docs(ko): improve Korean translation accuracy and clarity in Zen docs (anomalyco#13951)

* docs: improve zh-cn and zh-tw documentation translations (anomalyco#13942)

* fix(docs): correct reversed meaning in Korean plugins logging section (anomalyco#13945)

* chore: generate

* tweak(tui): new session banner with logo and details (anomalyco#13970)

* fix(app): recover state after sse reconnect and harden sse streams (anomalyco#13973)

* feat(app): session timeline/turn rework (anomalyco#13196)

Co-authored-by: David Hill <iamdavidhill@gmail.com>

* chore: app polish (anomalyco#13976)

Co-authored-by: David Hill <iamdavidhill@gmail.com>

* tweak(ui): icon button spacing

* chore: generate

* tweak(app): keep file tree toggle visible

Always show the titlebar file tree button (and space the right-side icon buttons at 4px) so it stays accessible regardless of the review panel state.

* tweak(app): reduce titlebar right padding

Use pr-2 (instead of pr-6) on the titlebar right section when not on Windows.

* tweak(app): use weak borders in titlebar actions

Use border-border-weak-base for the titlebar status and open actions (including the open button divider) and adjust the English copy-path label casing.

* tweak(app): match titlebar active bg to hover

Use the ghost hover background for active/expanded titlebar actions and tighten titlebar popover gutters to 4px.

* tweak(app): align titlebar search text size

Use the same 12px text style for the titlebar search placeholder as the status and open actions.

* tweak(ui): center titlebar search and soften keybind

Mount the titlebar search in the center area and tune its sizing/spacing; use regular weight for the keybind pill text.

* tweak(app): refine titlebar search and open padding

Ensure the titlebar search placeholder truncates cleanly and left-aligns; match the fallback copy-path button left padding to the open action.

* tweak(app): tighten titlebar action padding

Use pr-2 for the status and fallback copy-path actions, and tighten the copy icon/text gap to 1.5.

* tweak(ui): update magnifying-glass icon

Replace the magnifying-glass glyph with a 16px viewBox variant and keep default 1px stroke; adjust the titlebar search to render the icon at 16x16.

* feat(desktop): more e2e tests (anomalyco#13975)

* chore: generate

* tweak(ui): show user message meta on hover

Adds a hover-only metadata line under user messages showing agent, provider, model, and timestamp for quicker context.

* tweak(ui): use provider catalog names

Renders provider and model display names from the provider list instead of raw IDs in user message hover metadata.

* tweak(ui): refine user message hover meta

Moves the interrupted state into the user message hover metadata and updates the copy tooltip to 'Copy message'.

* tweak(ui): show assistant response meta on hover

Adds hover-only metadata after the assistant copy icon showing agent, provider, model, and response duration.

* tweak(ui): allow full-width user message meta

Moves the user message meta row out of the bubble width constraints and truncates long metadata while keeping the timestamp visible with consistent middot spacing.

* ui: add clearer 'Copy response' tooltip label for text parts

* tui: increase prompt mode toggle height for better clickability

* fix(desktop): avoid sidecar health-check timeout on shell startup (anomalyco#13925)

Co-authored-by: Brendan Allan <brendonovich@outlook.com>

* fix(app): ui flashing when switching tabs (anomalyco#13978)

* fix: Homepage video section layout shift (anomalyco#13987)

---------

Co-authored-by: Goni Zahavy <goni1993@gmail.com>
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Co-authored-by: Brendan Allan <brendonovich@outlook.com>
Co-authored-by: Frank <frank@anoma.ly>
Co-authored-by: Ganesh <179367536+itskritix@users.noreply.github.com>
Co-authored-by: vynn <163614291+vynnlee@users.noreply.github.com>
Co-authored-by: chenmi <jack_chenyuana@163.com>
Co-authored-by: Minung Han <hmu332233@gmail.com>
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
Co-authored-by: David Hill <1879069+iamdavidhill@users.noreply.github.com>
Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
Co-authored-by: Adam <2363879+adamdotdevin@users.noreply.github.com>
Co-authored-by: David Hill <iamdavidhill@gmail.com>
Co-authored-by: Filip <34747899+neriousy@users.noreply.github.com>
Co-authored-by: Chris Yang <18487241+ysm-dev@users.noreply.github.com>
Co-authored-by: Alex Carpenter <im.alexcarpenter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop sidecar spawn can time out on macOS with interactive shell startup

2 participants