Open
Conversation
| }) | ||
| const updated = patchJsonc(before, config) | ||
| await Bun.write(filepath, updated) | ||
| } else { |
Contributor
There was a problem hiding this comment.
we should try to avoid 'else' statements. See https://github.com/anomalyco/opencode/blob/dev/CONTRIBUTING.md#style-preferences
Is it possible to rewrite?
| for (const endpoint of uniqueEndpoints) { | ||
| if (Object.keys(models).length > 0) break | ||
|
|
||
| try { |
Contributor
There was a problem hiding this comment.
we should avoid try/catch as well, possible to rewrite?
https://github.com/anomalyco/opencode/blob/dev/CONTRIBUTING.md#style-preferences
| log.error(msg); | ||
| // AI SDK often swallows body text on 429. Injecting into statusText helps it surface. | ||
| Object.defineProperty(res, 'statusText', { value: msg }); | ||
| } catch (e) { |
Contributor
There was a problem hiding this comment.
same as above, try/catch
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #13537
Type of change
What does this PR do?
OPEN_WEBUI_API_KEY&OPEN_WEBUI_BASE_URLHow did you verify your code works?
Screenshots / recordings
None
Checklist