feat: replace csharp-ls with roslyn-language-server#14463
Merged
Hona merged 6 commits intoanomalyco:devfrom Apr 21, 2026
Merged
feat: replace csharp-ls with roslyn-language-server#14463Hona merged 6 commits intoanomalyco:devfrom
Hona merged 6 commits intoanomalyco:devfrom
Conversation
github-actions
Bot
added
the
needs:compliance
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
1 task
|
Just spent the afternoon implementing this myself! ➕ |
Member
|
heya @jmbryan4 the rosyln team says their LSP is good now - can you update this PR from dev + remove the flag. |
Bring the branch current with upstream dev (2014 commits). Resolves conflicts in flag.ts, lsp/index.ts, and lsp/server.ts by taking the upstream refactored structure and applying the roslyn swap on top.
jmbryan4
changed the title
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
Author
|
@Hona great! I updated the PR |
Member
|
thanks @jmbryan4 presumably you've tested within a C# project using |
Hona
reviewed
Apr 21, 2026
Comment on lines
+725
to
+726
| "--tool-path", | ||
| Global.Path.bin, |
Member
There was a problem hiding this comment.
lets just drop these 2 - global is okay here
Contributor
Author
yes |
Hona
approved these changes
Apr 21, 2026
Member
|
thank you - nice work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14462
Type of change
What does this PR do?
Replaces
csharp-lswithroslyn-language-serveras the default C# LSP. (@Hona confirmed this on 2026-04-20 with the Roslyn team).The
CSharpexport inlsp/server.tsnow installsroslyn-language-serverviadotnet tool install --global roslyn-language-server --prereleaseand starts it with--stdio --autoLoadProjects. The server id stays"csharp"so existing user configs are unaffected.How did you verify your code works?
Screenshots / recordings
N/A — no UI changes.
Checklist