fix(nix): include .github/TEAM_MEMBERS in fileset#15401
Open
jerome-benoit wants to merge 6 commits intoanomalyco:devfrom
Open
fix(nix): include .github/TEAM_MEMBERS in fileset#15401jerome-benoit wants to merge 6 commits intoanomalyco:devfrom
jerome-benoit wants to merge 6 commits intoanomalyco:devfrom
Conversation
After anomalyco#15369, the build script reads `.github/TEAM_MEMBERS` at build time, but this file was not included in the Nix source fileset. Also add the file to nix-hashes.yml paths trigger so hash regeneration is triggered when the file changes. Fixes anomalyco#15400
github-actions
bot
added
needs:compliance
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a reported Nix build failure (issue #15400) by including .github/TEAM_MEMBERS in the nix/node_modules.nix fileset and adding a path trigger for hash regeneration in the CI workflow.
Changes:
- Add
../.github/TEAM_MEMBERSto the fileset innix/node_modules.nix - Add
.github/TEAM_MEMBERSas a path trigger in.github/workflows/nix-hashes.yml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
nix/node_modules.nix |
Adds .github/TEAM_MEMBERS to the source fileset so it is available during the Nix build |
.github/workflows/nix-hashes.yml |
Triggers hash regeneration when .github/TEAM_MEMBERS changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TEAM_MEMBERS is not read during bun install phase, so it doesn't affect node_modules hash. Only the fileset change is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15400
Type of change
What does this PR do?
After #15369,
packages/script/src/index.tsreads.github/TEAM_MEMBERSat build time. This file wasn't included innix/node_modules.nixfileset, causing ENOENT during Nix builds.This PR adds
../.github/TEAM_MEMBERSto the fileset innix/node_modules.nix.How did you verify your code works?
nix buildnow proceeds past the TEAM_MEMBERS file read.Screenshots / recordings
N/A - not a UI change
Checklist