Skip to content

revert: undo turbo typecheck dependency change from #14828#15902

Merged
Hona merged 2 commits intodevfrom
copilot/revert-pull-14828
Mar 3, 2026
Merged

revert: undo turbo typecheck dependency change from #14828#15902
Hona merged 2 commits intodevfrom
copilot/revert-pull-14828

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

Issue for this PR

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

PR #14828 introduced a typecheck -> ^build dependency in Turborepo. This PR reverts that change to restore the previous task graph behavior.

  • Reverted task graph change
    • turbo.json tasks.typecheck is restored from:
      { "dependsOn": ["^build"] }
      back to:
      {}
  • Scope
    • Single-file change (turbo.json), no functional changes outside task orchestration.

How did you verify your code works?

Confirmed the revert matches the inverse of #14828 and that turbo.json remains valid JSON after the edit.

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: Hona <10430890+Hona@users.noreply.github.com>
Copilot AI changed the title [WIP] Revert changes from pull request #14828 revert: undo turbo typecheck dependency change from #14828 Mar 3, 2026
Copilot finished work on behalf of Hona March 3, 2026 21:26
@github-actions github-actions bot added needs:compliance This means the issue will auto-close after 2 hours. needs:title labels Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Hey! Your PR title [WIP] Revert changes from pull request #14828 doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Hey! Your PR title revert: undo turbo typecheck dependency change from #14828 doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@Hona Hona marked this pull request as ready for review March 3, 2026 21:35
Copilot AI review requested due to automatic review settings March 3, 2026 21:35
@Hona Hona merged commit 9a42927 into dev Mar 3, 2026
15 checks passed
@Hona Hona deleted the copilot/revert-pull-14828 branch March 3, 2026 21:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the Turborepo task graph change introduced in #14828 by removing the typecheck -> ^build dependency, restoring prior orchestration behavior.

Changes:

  • Reverted tasks.typecheck.dependsOn so typecheck no longer depends on parent build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:compliance This means the issue will auto-close after 2 hours. needs:title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants