fix: sdk.responses fallback + codex baseURL correction#16048
Open
coleleavitt wants to merge 1 commit intoanomalyco:devfrom
Open
fix: sdk.responses fallback + codex baseURL correction#16048coleleavitt wants to merge 1 commit intoanomalyco:devfrom
coleleavitt wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
Bot
added
contributor
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
- Add fallback checks for sdk.responses in openai, azure, azure-cognitive-services loaders - Fix gpt-5.3-codex to use correct OpenAI API baseURL instead of ChatGPT backend endpoint
coleleavitt
force-pushed
the
fix/sdk-responses-undefined-fallback
branch
from
1761c93 to
3d96c60
Compare
coleleavitt
changed the title
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
This PR is critical for my usecase, thanks for making it! For the time being, I have manually built opencode with this PR, but it would be much appreciated if this can be merged. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16049
Type of change
What does this PR do?
Fixes two related bugs when switching between AI models:
1. SDK responses fallback (provider.ts)
The
openai,azure, andazure-cognitive-servicesloaders callsdk.responses(modelID)unconditionally. But@ai-sdk/openai-compatibledoesn't have a.responses()method - only.languageModel(). When switching to a model using that SDK, it crashes withTypeError: sdk.responses is not a function.Fix: Added checks before calling
sdk.responses(). If undefined, fall back tosdk.languageModel(modelID). This matches what thegithub-copilotloader already does.2. Codex baseURL (codex.ts)
The
gpt-5.3-codexmodel hadapi.urlset tohttps://chatgpt.com/backend-api/codexwhich is a ChatGPT internal endpoint, not the OpenAI API. This caused requests to route incorrectly when switching models.Fix: Changed to
https://api.openai.com/v1.How did you verify your code works?
Screenshots / recordings
N/A - not a UI change
Checklist