refactor(desktop): improve error handling and translation in server error formatting#16171
Merged
adamdotdevin merged 1 commit intoanomalyco:devfrom Mar 5, 2026
Merged
Conversation
…rror formatting - Updated `formatServerError` to accept a translation function for better localization. - Simplified error handling in `createGlobalSync` and `bootstrapGlobal` by using the new translation approach. - Added tests for new error formatting behavior, including handling of provider model not found errors.
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
1 similar comment
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16168
Type of change
What does this PR do?
formatServerErrorto accept a translation function for better localization, rather than having to pass in the text per error type which im the long term will be a hassle to manage, this way any error can be passed in as as long as it satisfies the condition of a recognised error we are able to send the right error message in the right language.createGlobalSyncandbootstrapGlobalby using the new translation approach.How did you verify your code works?
Tested on the local dev env
Screenshots / recordings
Screen.Recording.2026-03-05.at.12.57.07.mov
Checklist