feat(opencode): surface lsp diagnostics on read#16592
Open
mmsaki wants to merge 3 commits intoanomalyco:devfrom
Open
feat(opencode): surface lsp diagnostics on read#16592mmsaki wants to merge 3 commits intoanomalyco:devfrom
mmsaki wants to merge 3 commits intoanomalyco:devfrom
Conversation
20659a7 to
74585fd
Compare
Author
|
@thdxr is this a valid contribution see demo? |
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16569
Type of change
What does this PR do?
Adds a diagnostics operation to the built-in lsp tool and updates read to surface current-file LSP diagnostics when a language server is available.
The lsp tool now accepts file-level diagnostics without requiring line/character, while position-based operations still require them. The read tool now attaches warning/error diagnostics for the current file as a best-effort enhancement and keeps normal read behavior if diagnostics lookup fails.
How did you verify your code works?
Screenshots / recordings
openode-diagnostics.mp4
Checklist