Skip to content

fix(app): dismiss toast notifications when questions or permissions a…#16758

Merged
adamdotdevin merged 1 commit intoanomalyco:devfrom
neriousy:fix/dismiss-question-permission-toasts
Mar 9, 2026
Merged

fix(app): dismiss toast notifications when questions or permissions a…#16758
adamdotdevin merged 1 commit intoanomalyco:devfrom
neriousy:fix/dismiss-question-permission-toasts

Conversation

@neriousy
Copy link
Contributor

@neriousy neriousy commented Mar 9, 2026

Issue for this PR

Closes #67

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Often when running tests locally toasts about permissions or questions pop up, and even though they're already anwsered (cause they've been anwsered programitacally) the toast linger.

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

Run e2e tests locally about questions & look how the toast dissapear

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@neriousy neriousy requested a review from adamdotdevin as a code owner March 9, 2026 13:47
Copilot AI review requested due to automatic review settings March 9, 2026 13:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds event handling logic to automatically dismiss toast notifications in the UI when questions or permissions are answered programmatically (replied to or rejected). Previously, toasts for permission.asked and question.asked events would linger even after the underlying request had been resolved.

Changes:

  • Added a new event handler block in useSDKNotificationToasts that listens for question.replied, question.rejected, and permission.replied events and dismisses the corresponding toast notification using the existing dismissSessionAlert helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamdotdevin adamdotdevin merged commit 3742e42 into anomalyco:dev Mar 9, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] how to use typescript-go lsp

3 participants