feat(skill): expand shell directives in skill content (#10892)#17540
Open
rylwin wants to merge 1 commit intoanomalyco:devfrom
Open
feat(skill): expand shell directives in skill content (#10892)#17540rylwin wants to merge 1 commit intoanomalyco:devfrom
rylwin wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Why they're related: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #10892
Type of change
What does this PR do?
Support the !`command` syntax in skills to inject dynamic content at load time, compatible with Claude Code's implementation.
I know there's another PR implementing the same feature, but I think it's stalled out due to feedback needing to be addressed (#10891).
How did you verify your code works?
To manaully QA, I ran opencode with the following prompt (which references a personal skill of mine that uses a shell directive to include a script's help in the skill markdown file):
When I run opencode on
dev, I get answers like:When I run opencode on this branch / PR, I get answers like:
Checklist
Happy to address any feedback. And thanks for opencode!