Remove CLI from electron app#17803
Open
Brendonovich wants to merge 3 commits intorefactor/npm-over-bunprocfrom
Open
Remove CLI from electron app#17803Brendonovich wants to merge 3 commits intorefactor/npm-over-bunprocfrom
Brendonovich wants to merge 3 commits intorefactor/npm-over-bunprocfrom
Conversation
Brendonovich
commented
Mar 17, 2026
packages/opencode/script/build.ts
Outdated
| await Bun.write( | ||
| path.join(dir, "src/provider/models-snapshot.ts"), | ||
| `// Auto-generated by build.ts - do not edit\nexport const snapshot = ${modelsData} as const\n`, | ||
| `// Auto-generated by build.ts - do not edit\nexport const snapshot = ${modelsData} as Record<string, unknown>\n`, |
Member
Author
There was a problem hiding this comment.
Changed this as the const type is too large for ts to generate
Brendonovich
commented
Mar 17, 2026
Comment on lines
+797
to
+801
| const sessionID = c.req.valid("param").sessionID | ||
| const body = c.req.valid("json") | ||
| SessionPrompt.prompt({ ...body, sessionID }) | ||
|
|
||
| return c.body(null, 204) |
Member
Author
There was a problem hiding this comment.
Node isn't happy when returning a 204 with a body
Brendonovich
changed the base branch from
opencode-2-0
to
refactor/oauth-node-http
Brendonovich
force-pushed
the
brendan/electron-remove-cli
branch
from
7010a05 to
8fc5f8a
Compare
Brendonovich
force-pushed
the
brendan/electron-remove-cli
branch
from
9154038 to
f501d3c
Compare
Contributor
|
This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch Please resolve this issue to include this PR in the next beta release. |
2 similar comments
Contributor
|
This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch Please resolve this issue to include this PR in the next beta release. |
Contributor
|
This PR cannot be merged into the beta branch due to: Merge conflicts with dev branch Please resolve this issue to include this PR in the next beta release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server.listenin the Electron main processsyncClifunctionality has been removed as CLI is no longer bundled with the appTODO
composite: true?)