Effectify ToolRegistry service#18269
Closed
kitlangton wants to merge 8 commits into
Closed
Conversation
Constrain BusEvent.define to ZodObject instead of ZodType so TS knows
event properties are always a record. Type GlobalBus payload as
{ type: string; properties: Record<string, unknown> } instead of any.
Refactor watcher test to use Bus.subscribe instead of raw GlobalBus
listener, removing hand-rolled event types and unnecessary casts.
… pattern Replace the legacy Instance.state() lazy init with an Effect Layer that yields InstanceContext, defines Interface/Service/layer, and exposes promise facades for backward compat. Register ToolRegistry.Service in the Instances layer map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolRegistryfrom legacyInstance.state()pattern to the Effect service pattern (Interface / Service / Layer / promise facades)Instance.directory/Instance.worktreeinfromPluginwithInstanceContextclosure variablesToolRegistry.Servicein theInstanceslayer mapToolRegistryas done in effect-migration.mdTest plan
bun run typecheckshows no new errors (all errors are pre-existing effect/zod version mismatches)bun run testshows no new failuresInstance.stateno longer appears intool/registry.tsprompt.ts,experimental.ts,batch.ts,agent.ts) work unchanged via promise facades