Skip to content

feat(acp): Add messageID and emit user_message_chunk on prompt/command#18625

Merged
rekram1-node merged 6 commits intoanomalyco:devfrom
noamzbr:feat/18622-acp-message-id
Apr 2, 2026
Merged

feat(acp): Add messageID and emit user_message_chunk on prompt/command#18625
rekram1-node merged 6 commits intoanomalyco:devfrom
noamzbr:feat/18622-acp-message-id

Conversation

@noamzbr
Copy link
Copy Markdown
Contributor

@noamzbr noamzbr commented Mar 22, 2026

Issue for this PR

Closes #18622

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

  1. Adds messageID to the ACP ContextChunks created by the acp adapter
  2. Call processMessage also on user messages in the live path. This is so the updates seen on the "live" (prompt / command) path are the same to what is emitted when hitting /load (replay path) - which does emit these chunks for the user messages

Note

Opencode messageID are not UUID, so this is not strictly speaking compliant with the experimental ACP messageID standard.
I personally think that the standard should adapt to allow for ACP messageID to actually be the internal messageID stored and managed by the agent server - otherwise clients can't use it to interface directly with the server when needed (e.g. - revert)

How did you verify your code works?

Used the emitted messageIds to revert messages, and reconcile the same message between live (prompt) path and reload path.

Screenshots / recordings

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@noamzbr noamzbr force-pushed the feat/18622-acp-message-id branch from e48b053 to 246bc7f Compare March 22, 2026 12:14
atharvau

This comment was marked as spam.

@noamzbr noamzbr marked this pull request as draft March 24, 2026 08:50
@noamzbr noamzbr force-pushed the feat/18622-acp-message-id branch from 246bc7f to 5482973 Compare March 24, 2026 14:21
@noamzbr noamzbr marked this pull request as ready for review March 24, 2026 14:25
@noamzbr noamzbr force-pushed the feat/18622-acp-message-id branch from 7d42a7f to 91ea443 Compare March 24, 2026 16:37
@rekram1-node rekram1-node merged commit 1989704 into anomalyco:dev Apr 2, 2026
9 checks passed
cavaldos pushed a commit to cavaldos/openpentest that referenced this pull request Apr 6, 2026
anomalyco#18625)

Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add ACP messageId

3 participants