fix(session): sanitize part IDs after plugin hooks#18788
Open
CybLow wants to merge 1 commit intoanomalyco:devfrom
Open
fix(session): sanitize part IDs after plugin hooks#18788CybLow wants to merge 1 commit intoanomalyco:devfrom
CybLow wants to merge 1 commit intoanomalyco:devfrom
Conversation
…validation crash Plugins that hook into chat.message can push new parts into the parts array with non-compliant IDs (missing the required prt prefix). This causes Session.updatePart() to throw a ZodError since v1.2.25 when branded PartID validation was introduced (anomalyco#16966). After Plugin.trigger(chat.message) returns, re-assign any invalid part IDs with PartID.ascending() so misbehaving plugins cannot crash the core. Fixes anomalyco#18780
github-actions
bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18780
Type of change
What does this PR do?
Since v1.2.25 (#16966), all part IDs must start with
"prt"(enforced byPartID.zod=z.string().startsWith("prt")). ThecreateUserMessage()function inprompt.tscorrectly generates compliant IDs via theassign()function. However, it then callsPlugin.trigger("chat.message", ..., { message: info, parts }), passing thepartsarray by reference to plugin hooks.Plugins like
opencode-supermemorypush new parts into this array with non-compliant IDs (e.g.,supermemory-nudge-*,supermemory-context-*). WhenSession.updatePart()is called afterwards,fn(MessageV2.Part, ...)runsPartID.zod.parse()and throws a ZodError, crashing the session.This fix adds a sanitization loop after
Plugin.trigger("chat.message")returns: any part with a missing or non-"prt"prefixed ID gets reassigned a validPartID.ascending(). This protects the core against misbehaving plugins without breaking any existing behavior — parts that already have valid IDs are left untouched.How did you verify your code works?
fn()inutil/fn.tsthroughSession.updatePart()back tocreateUserMessage()opencode-supermemoryplugin injects parts withsupermemory-nudge-*andsupermemory-context-*IDs atdist/index.js:14548,14582Screenshots / recordings
Not a UI change.
Checklist