Open
Conversation
- Add 6 tests for list, get, setInitialized, addSandbox, removeSandbox - Replace fn() wrapper on update with plain async function + UpdateInput schema - Update route validator to use Project.UpdateInput - Check off Project in migration checklist
…sync for DB - gitRun helper for initGit (ChildProcessSpawner pattern) - FileSystem for discover (readFile) and sandboxes (exists) - Effect.sync wrapper for all Database.use calls - emitUpdated helper for GlobalBus events - fromDirectory stays as Effect.promise (complex, convert incrementally) - defaultLayer provides Node platform implementations
- Convert all git calls to ChildProcessSpawner-based git helper - Use FileSystem for cached ID read/write and sandbox existence checks - Use Path for all path resolution (no more raw path module) - Use db() for all Database operations (select, upsert, session migration) - Parallel sandbox existence checks via Effect.forEach + concurrency - Remove iife, existsSync dependencies
kitlangton
force-pushed
the
kit/effectify-project
branch
from
5092adb to
50beb01
Compare
- Replace Filesystem/Glob/existsSync with AppFileSystem.Service
- Replace NodeChildProcessSpawner with CrossSpawnSpawner
- Promise-based API delegates to runPromise (fromDirectory, discover,
update, initGit, sandboxes, addSandbox, removeSandbox)
- list/get/setInitialized stay sync (callers depend on it)
- Extract fakeVcs const, use fsys.isDir for sandbox filtering
- Preserve stdin:"ignore" on git spawns, which("git") in initGit
- Use Effect.forkIn(scope) for fire-and-forget discover
- Update tests: remove mock.module for util/git, use Bun.file
commonDir and topLevel failures must return early with fakeVcs, matching old .catch(() => undefined) behavior. rev-list failures intentionally fall through (empty roots → vcs: "git"), same as dev.
Re-add tests for rev-list, show-toplevel, and git-common-dir failures. Old tests mocked util/git (no longer imported); new tests use a real git shim on PATH that intercepts specific subcommands, matching the pattern from worktree-remove.test.ts.
Replace PATH shim approach with a proper Effect mock layer that intercepts specific git subcommands and returns exit code 128. Uses the same mockSpawner pattern from installation.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChildProcessSpawner+ChildProcess.makefor all git operationsFileSystemfor cached ID read/write, sandbox existence, icon discoveryPathfor all path resolutiondb()helper wrapsDatabase.usefor clean Effect.sync DB accessfromDirectoryfully effectful — git detection, ID caching, upsert, session migrationfn()wrapper on update withUpdateInputschemaTest plan
fromDirectory: git repos, worktrees, commits, no-gitdiscover: favicon detectionupdate: name, icon, commands, multi-field, not-found error, GlobalBus eventslist,get,setInitialized,addSandbox,removeSandbox