docs(acp): update ACP README to reflect current architecture#18911
Open
soddygo wants to merge 6 commits intoanomalyco:devfrom
Open
docs(acp): update ACP README to reflect current architecture#18911soddygo wants to merge 6 commits intoanomalyco:devfrom
soddygo wants to merge 6 commits intoanomalyco:devfrom
Conversation
- Remove references to deleted server.ts and client.ts - Add Server Startup section pointing to cli/cmd/acp.ts - Update Permission Handling section to match current implementation - Remove outdated Programmatic usage example - Fix Clean Architecture section to accurately describe components
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Update the ACP README to reflect current code structure after refactoring in PR #3403.
The
server.tsandclient.tsfiles were removed in commit 98d51dd, but the README was not updated accordingly, causing documentation to be out of sync with the actual code.Changes:
server.tsandclient.tsfilescli/cmd/acp.tsACPServer.start())How did you verify your code works?
packages/opencode/src/acp/cli/cmd/acp.tsexists and contains the server startup logicserver.tsandclient.tswere deleted in commit 98d51ddScreenshots / recordings
N/A - Documentation change only
Checklist