Skip to content

fix(app): resume sessions in desktop app#19157

Closed
anduimagui wants to merge 13 commits intoanomalyco:devfrom
anduimagui:andrew/desktop-session-resume
Closed

fix(app): resume sessions in desktop app#19157
anduimagui wants to merge 13 commits intoanomalyco:devfrom
anduimagui:andrew/desktop-session-resume

Conversation

@anduimagui
Copy link
Copy Markdown
Contributor

Summary

  • wire the app session route through the existing session resume lifecycle so desktop resumes existing sessions when reopening them
  • skip the first resume call for brand-new sessions and fresh forks so only true reopen flows trigger resume
  • add focused unit coverage for the shared app resume helper

Notes

  • this depends on feat(session): add session.start lifecycle hook #18007 and is intended to be reviewed after or alongside it
  • because the base branch cannot live in anomalyco/opencode without push access, this upstream PR includes the full #18007 stack plus the desktop follow-up

Verification

  • bun test src/pages/session/session-resume.test.ts (blocked in this checkout because packages/app/happydom.ts imports missing @happy-dom/global-registrator)
  • bun typecheck in packages/app (blocked in this checkout by existing workspace dependency resolution issues)

@github-actions github-actions bot added the needs:compliance This means the issue will auto-close after 2 hours. label Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one potentially related PR:

#18007: feat(session): add session.start lifecycle hook

This PR is related because:

No other duplicate PRs were found. The other search results (like #19116 on reconnect logic and #7756 on session delegation) address different aspects of session management but are not duplicates of this specific fix for resuming sessions in the desktop app.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 25, 2026
@github-actions github-actions bot closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants