Skip to content

fix: bump gitlab-ai-provider to 5.3.3 for DWS tool approval support#19185

Merged
rekram1-node merged 4 commits intoanomalyco:devfrom
vglafirov:vg/tools-fix
Mar 26, 2026
Merged

fix: bump gitlab-ai-provider to 5.3.3 for DWS tool approval support#19185
rekram1-node merged 4 commits intoanomalyco:devfrom
vglafirov:vg/tools-fix

Conversation

@vglafirov
Copy link
Contributor

@vglafirov vglafirov commented Mar 26, 2026

Issue for this PR

Closes #19186

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Bumps gitlab-ai-provider from 5.3.2 to 5.3.3 to fix workflow model tools being silently cancelled.

DWS has a multi-layered tool approval system. The server only pre-approves certain privilege groups (read_write_files, read_only_gitlab), while tools in run_commands, run_mcp_tools, use_git, and read_write_gitlab require explicit approval. The provider was missing tool_approval_for_session_enabled: true in workflow metadata, so DWS silently discarded the client-side preapproved_tools list. When DWS then sent TOOL_CALL_APPROVAL_REQUIRED checkpoints, the provider didn't handle them, causing the stream to hang indefinitely.

Changes in gitlab-ai-provider 5.3.3:

  1. Added tool_approval_for_session_enabled: true to workflow metadata so DWS respects client-side preapproved tools
  2. Added TOOL_CALL_APPROVAL_REQUIRED to the processCheckpoint status allowlist
  3. Added TOOL_CALL_APPROVAL_REQUIRED / PLAN_APPROVAL_REQUIRED handling in the WebSocket client to prevent stream hangs

How did you verify your code works?

  • Linked local gitlab-ai-provider build into opencode and verified the fix resolves to the correct dist
  • All 478 gitlab-ai-provider tests pass
  • opencode typecheck passes (13/13 packages)

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions bot added needs:compliance This means the issue will auto-close after 2 hours. contributor needs:issue labels Mar 26, 2026
@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 26, 2026
@github-actions
Copy link
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@rekram1-node rekram1-node enabled auto-merge (squash) March 26, 2026 00:07
@rekram1-node rekram1-node merged commit 7cb690d into anomalyco:dev Mar 26, 2026
9 checks passed
@vglafirov vglafirov deleted the vg/tools-fix branch March 26, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow model tools silently cancelled due to DWS tool approval

2 participants