fix: include credentials when fetching site.webmanifest#19302
Open
andybons wants to merge 1 commit intoanomalyco:devfrom
Open
fix: include credentials when fetching site.webmanifest#19302andybons wants to merge 1 commit intoanomalyco:devfrom
andybons wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
andybons
force-pushed
the
fix/webmanifest-credentials
branch
from
0d3412b to
264e454
Compare
andybons
force-pushed
the
fix/webmanifest-credentials
branch
from
264e454 to
ca85057
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #19301
Type of change
What does this PR do?
The
<link rel="manifest">tag fetches/site.webmanifestwithout credentials by default. When the web app is behind a Cloudflare proxy (e.g. Cloudflare Access), the request gets blocked because cookies aren't sent. Addingcrossorigin="use-credentials"tells the browser to include cookies with the manifest fetch. For users not behind a proxy, this is a no-op since same-origin requests already include cookies.Desktop app is left unchanged since it serves files locally.
How did you verify your code works?
bun run testinpackages/app: 299 pass, 0 failScreenshots / recordings
N/A — no UI change, only an HTML attribute addition.
Checklist