Merged
Conversation
kitlangton
force-pushed
the
effect/plugin-native
branch
from
6e22341 to
1be4f5f
Compare
…alls Convert the Plugin service's internal Effect.promise blocks to native Effect operations: - Yield Config.Service directly instead of calling Config.get() async facade - Use config.get() and config.waitForDependencies() as Effect yields - Use bus.publish() for error reporting instead of Bus.publish() async facade - Replace monolithic Effect.promise with granular Effect.tryPromise calls for BunProc.install, plugin loading, and plugin initialization - Convert trigger's Effect.promise loop to individual Effect.promise yields - Add Config.defaultLayer to Plugin's defaultLayer dependency chain
kitlangton
force-pushed
the
effect/plugin-native
branch
from
1be4f5f to
e82e280
Compare
# ------------------------ >8 ------------------------ # Do not modify or remove the line above. # Everything below it will be ignored. # # Conflicts: # packages/opencode/src/plugin/index.ts
# ------------------------ >8 ------------------------ # Do not modify or remove the line above. # Everything below it will be ignored. # # Conflicts: # packages/opencode/src/plugin/index.ts
auto-merge was automatically disabled
March 27, 2026 14:41
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Effect.promisein Plugin's state initializer with granular native Effect callsConfig.Servicedirectly instead of callingConfig.get()/Config.waitForDependencies()async facadesbus.publish()(yielded service) for error reporting instead ofBus.publish()async facadeBunProc.install, plugin loading, and plugin init to individualEffect.tryPromisecalls with proper error handling viaEffect.catchAlltrigger'sEffect.promiseloop to per-hookEffect.promiseyieldsTest plan
bun run typecheckpasses (no new errors vs baseline)zodresolution issue)