fix(opencode): clarify git amend condition to require verifying commit landed#19937
Open
altendky wants to merge 10 commits intoanomalyco:devfrom
Open
fix(opencode): clarify git amend condition to require verifying commit landed#19937altendky wants to merge 10 commits intoanomalyco:devfrom
altendky wants to merge 10 commits intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #19936
Type of change
What does this PR do?
Adjusts condition (1) in the git amend guidance to make explicit that the agent must verify the commit actually landed (via
git log) before amending. This prevents incorrect amends when pre-commit hooks modify files but the commit itself failed.The original wording "commit SUCCEEDED" was ambiguous — when hooks modify files, the agent sees modified files regardless of whether the commit landed. Different hook frameworks behave differently (pre-commit blocks on modification, lint-staged/Lefthook can succeed), so explicit verification is necessary.
How did you verify your code works?
Read the updated guidance and confirmed it now explicitly requires checking
git logto verify HEAD is the new commit before amending.Screenshots / recordings
N/A
Checklist