fix(build-node): preserve Bun linker for node-pty install#20364
Open
Hona wants to merge 1 commit intoanomalyco:refactor/hono-serverfrom
Open
fix(build-node): preserve Bun linker for node-pty install#20364Hona wants to merge 1 commit intoanomalyco:refactor/hono-serverfrom
Hona wants to merge 1 commit intoanomalyco:refactor/hono-serverfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the packages/opencode Node build script to ensure that when it runs a follow-up bun install for @lydell/node-pty, it uses the same Bun linker mode (hoisted vs isolated) as the current workspace install layout—avoiding mixed install layouts (notably on Windows in GITHUB_ACTIONS).
Changes:
- Add linker-mode detection by inspecting workspace/root
node_modulesplacement (with a fallback based onbun.lock+ workspace config). - Pass
--linker=<detected>to thebun install ... @lydell/node-pty@...step inbuild-node.ts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun install@lydell/node-ptyso the WindowsGITHUB_ACTIONSpath does not mix hoisted and isolated installsbuild-node.tsaligned with the existing install method instead of falling back to the monorepo defaultTesting
GITHUB_ACTIONS=true bun --cwd packages/opencode script/build-node.tsbun turbo typecheck(via pre-push hook)