refactor: add Effect-returning versions of MessageV2 functions#20374
Open
kitlangton wants to merge 1 commit intodevfrom
Open
refactor: add Effect-returning versions of MessageV2 functions#20374kitlangton wants to merge 1 commit intodevfrom
kitlangton wants to merge 1 commit intodevfrom
Conversation
Extract sync cores (partsSync, getSync, pageSync) from MessageV2 DB functions and add Effect.fn wrappers: partsEffect, getEffect, pageEffect, streamEffect, filterCompactedEffect, toModelMessagesEffect. Replace all Effect.promise(() => MessageV2.*) call sites in processor, prompt, compaction, session index, and tests with direct yield* calls.
kitlangton
force-pushed
the
worktree-effectify-message-v2
branch
from
428e2cd to
af3f77f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partsSync,getSync,pageSync) from MessageV2 DB functions that were unnecessarilyasync(allDatabase.usecalls are synchronous)Effect.fnexports:partsEffect,getEffect,pageEffect,streamEffect,filterCompactedEffect,toModelMessagesEffectEffect.promise(() => MessageV2.*)call sites with directyield*calls across processor, prompt, compaction, session index, and testsTest plan
bun run test -- test/session/processor-effect— 10/10 passbun run test -- test/session/prompt-effect— 25/25 passbun run test -- test/session/— 180/180 pass (4 skipped)