Skip to content

perf(review): defer offscreen diff mounts#20469

Merged
nexxeln merged 2 commits intodevfrom
nxl/viewport-review-diffs
Apr 1, 2026
Merged

perf(review): defer offscreen diff mounts#20469
nexxeln merged 2 commits intodevfrom
nxl/viewport-review-diffs

Conversation

@nexxeln
Copy link
Copy Markdown
Member

@nexxeln nexxeln commented Apr 1, 2026

summary

  • only mount expanded review diffs when they are in or near the viewport, while keeping focused rows pinned
  • group review comments per file once and render offscreen rows as placeholders to reduce expand-all work

testing

  • bun typecheck

@nexxeln nexxeln merged commit 44f8301 into dev Apr 1, 2026
9 checks passed
@nexxeln nexxeln deleted the nxl/viewport-review-diffs branch April 1, 2026 13:59
katosun2 pushed a commit to katosun2/opencode that referenced this pull request Apr 2, 2026
jeromelau pushed a commit to jeromelau/opencode that referenced this pull request Apr 2, 2026
balcsida pushed a commit to balcsida/opencode that referenced this pull request Apr 8, 2026
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant